Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable-3.13] avoid deadlock: cancel hydration requests coming from itself #6869

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Jul 1, 2024

Backport of PR #6868

our current infrastructure will cause a deadlock for any hydration
requests coming from desktop files client itself

the main thread is responsible for executing the hydration request but
if the same thread is already blocked waiting for the hydration to
happen, both (open system call and hydration request handling) process
will never be completed and wait for each over in a stuck cycle

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@backportbot backportbot bot requested review from claucambra and mgallien July 1, 2024 14:15
@backportbot backportbot bot added this to the 3.13.1 milestone Jul 1, 2024
@mgallien mgallien merged commit d8d7b03 into stable-3.13 Jul 1, 2024
9 of 12 checks passed
@mgallien mgallien deleted the backport/6868/stable-3.13 branch July 1, 2024 14:16
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-6869-3a34b396eae6ee6ccb7c91c1a6f55e6cf5fc719f-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

Copy link

sonarcloud bot commented Jul 1, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants